Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PreSmalltalks] Investigate corner cases for concat #285

Open
shingarov opened this issue May 22, 2024 · 0 comments
Open

[PreSmalltalks] Investigate corner cases for concat #285

shingarov opened this issue May 22, 2024 · 0 comments
Assignees

Comments

@shingarov
Copy link
Owner

SequenceableCollection>>concat (which should really be renamed to #join) contains the following comment:

"In the special case of empty receiver, answer #()."

and then this code:

self isEmpty ifTrue: [^#()].

I am starting to think this is nonsense. #concat is MacLane's μ :: T²→T. In order for T² to make sense, the species of the outer collection must match the species of the inner collection.

@shingarov shingarov self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant