-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion in isRVarApp
#264
Draft
shingarov
wants to merge
133
commits into
pure-z3
Choose a base branch
from
issue-255
base: pure-z3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please do not merge this code.
It is clearly a PLE thing.
Both MA (prior this commit) and upstream Sprite (at the time of this commit) had bug in type renaming where parameters were renamed but not references to them in termination metric. All tests "appeared to work" simply because the code used same (formal) parameter names in both type signature and function declaration. However in general case they do not need to be the same. Solution is simple - also rename parameters in termination metric.
…g tail elimination of EIf
Now L8 test_abs_* pass.
The code was actually malformed because metric referred to function's formal parameter (not parameter in signature!)
test_abs_03 and test_abs_04 are just like test_abs_02 except they use bitvectors instead of int.
We shall write a meaningful one when the time comes.
The prover found a subtle bug!
NB: This is NOT the neg test illustrating Issue#265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.