Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version prefix #33

Open
kevnm67 opened this issue Nov 20, 2019 · 3 comments
Open

Support version prefix #33

kevnm67 opened this issue Nov 20, 2019 · 3 comments

Comments

@kevnm67
Copy link

kevnm67 commented Nov 20, 2019

Building off #22, what are your thoughts on either providing an option or inferring a version prefix from the latest tags? (e.g. v from v1.1.0).

Also, adding the version bump inference to the docs would be helpful.

I'd be happy to contribute to either if you want/open to PR's.

@orta
Copy link
Member

orta commented Nov 21, 2019

I'm into it 👍

Extra kudos if doing that also updates the README references from the old version string to the new one

@f-meloni
Copy link
Member

I'm into it too 👍

I would suggest to add a field to define a version pattern, that could then scale from the future, and have two variables instead of just $VERSION like now.

  • one gives you just the semantic version e.g. 1.1.0
  • one gives you the entire version tag e.g. v1.1.0

Obviously if you don't use any custom pattern those two are equal

@kevnm67
Copy link
Author

kevnm67 commented Nov 21, 2019

@orta Definitely includes updating the README. I stumbled on the option reading your closed issue.

@f-meloni Thanks for the suggestion! Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants