Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognizable colors in simple terminal #14

Open
fjbaldon opened this issue Dec 11, 2022 · 12 comments
Open

Unrecognizable colors in simple terminal #14

fjbaldon opened this issue Dec 11, 2022 · 12 comments

Comments

@fjbaldon
Copy link

https://imgur.com/a/UoDv8Aq

Attached is a screenshot where #include isn't being displayed correctly. I've patched st with st-no_bold_colors-0.8.1.diff and st-solarized-both-20220617-baa9357.diff .

@shaunsingh
Copy link
Owner

Does st support termguicolors?

@fjbaldon
Copy link
Author

I'm not on solarized rn but yes. Running :termguicolors changes some colors in st

@towry
Copy link

towry commented Dec 14, 2022

截屏2022-12-14 17 13 42

@stefumies
Copy link

Same here on Mac

@rzeigler
Copy link

To chime in, this seems to show good colors for me with background=light.

@cultab
Copy link

cultab commented Mar 10, 2023

I can replicate this in windows terminal, image and wezterm
image

It seems to not be st specific and affects all filetypes (in lua filetypes variables are affected instead of #defines).

@peterlvilim
Copy link

peterlvilim commented Mar 10, 2023

I'm also hitting this. Light seems to work fine but having trouble with dark. On mac and tried kitty and alacritty. Have tried messing with various different options but haven't found anything yet.
Screenshot 2023-03-10 at 13 17 49

@peterlvilim
Copy link

I think I maybe found the problem. I opened a pull request #18 with some example fixes but looking for feedback

@Sleepful
Copy link

Sleepful commented Apr 5, 2023

+1, I can confirm that @peterlvilim's is much more readable.

Notice the grey letters, those were impossible to read:
Screen Shot

Using Kitty terminal on OSX, having the same issues everyone described.

@Sleepful
Copy link

Sleepful commented Apr 5, 2023

for comparison:

Screen Shot

@peterlvilim
Copy link

I have a bunch of commits on my local machine cleaning up various things with dark mode beyond the example diff. It doesn’t fix everything quite yet but been fixing as I notice. Will try to open a pull request with it in next few days.

@lytex
Copy link

lytex commented Apr 8, 2023

Commit 34c2245 which is the one I had pined before, doesn't have this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants