Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if our shake time is one or two frames too long #14

Open
jon12156 opened this issue Oct 17, 2017 · 2 comments
Open

check if our shake time is one or two frames too long #14

jon12156 opened this issue Oct 17, 2017 · 2 comments

Comments

@jon12156
Copy link
Contributor

jon12156 commented Oct 17, 2017

I wonder if we are off by one or two frames for all garbage shaking.
the panel de pon shake counter counts upwards, and starts at 1 frame when the garbage is 1 row above it's landing space

in panel attack. the counter starts at the initial number of frames the screen is supposed to shake, and it starts at this initial number 1 frame after the garbage occupies it's landing space.

@jon12156
Copy link
Contributor Author

image

@jon12156
Copy link
Contributor Author

jon12156 commented Oct 17, 2017

ok so we are shaking the right number of frames, but we start shaking 2 frames too late!

sharpobject pushed a commit that referenced this issue Jun 8, 2018
made pressing esc during spectating or replay back you out of it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant