Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias on value extractors ? #29

Open
jeanibarz opened this issue Sep 22, 2020 · 0 comments
Open

Bias on value extractors ? #29

jeanibarz opened this issue Sep 22, 2020 · 0 comments

Comments

@jeanibarz
Copy link

jeanibarz commented Sep 22, 2020

Dear Shariq,

In your article, there is no bias used to calculate the x_i. However, in the code the bias is not set to False, and I believe that the default value is True, for the value extractors:

self.value_extractors.append(nn.Sequential(nn.Linear(hidden_dim,

Is there a reason for that ? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant