ShareDB CI Breakage #147
Description
The ShareDB CI pipeline seems impacted by recent changes here, as evidenced by this PR:
The output there reads:
Run scripts/test-sharedb-mongo.sh
Cloning into 'sharedb-mongo'...
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected].[4](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:5)
npm ERR! node_modules/sharedb
npm ERR! sharedb@"file:../sharedb" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer sharedb@"^1.0.0-beta || ^2.0.0" from [email protected]
npm ERR! node_modules/sharedb-mingo-memory
npm ERR! dev sharedb-mingo-memory@"^1.1.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2023-03-03T11_47_[5](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:6)8_0[7](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:8)2Z-debug-0.log
It looks like to do with
- the ShareDB major version bump (to v3)
- the peer dependencies list in sharedb-mingo-memory https://github.com/share/sharedb-mingo-memory/blob/master/package.json#L21 being updated
- the fact that this repo
sharedb-mongostill has a dependency on the older release ofsharedb-mingo-memory, which does not yet include v3 in the list of acceptable ShareDB versions
Proposed fix
I would guess that upgrading the sharedb-mingo-memory version here would solve the issue.
Also, for the sake of stability, it may be worth having ShareDB's scripts/test-sharedb-mongo.sh use a specific commit of this repository, as currently the CI of ShareDB is vulnerable to changes in this repo because that script always pulls the latest from here.
Cheers!