New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function doing redundant work? #31

Open

silver83p opened this issue Jun 11, 2024 · 0 comments

silver83p commented Jun 11, 2024

archive-server/src/ShardFunctions.ts

Line 161 in 30ef2fa

static calculatePartitionRangeInternal(

The third "if" statement seems like it will redo all the calculations in the first two.

(Also, could there be a case where there's a split range and we somehow wind up with "start < end" and we don't catch that? What would happen?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment