Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TradeAssetSelect is aggregating balances while we don't necessary need to have the balances of every accounts #8583

Open
NeOMakinG opened this issue Jan 15, 2025 · 0 comments
Open

TradeAssetSelect is aggregating balances while we don't necessary need to have the balances of every accounts #8583

NeOMakinG opened this issue Jan 15, 2025 · 0 comments

Comments

@NeOMakinG
Copy link
Collaborator

Overview

On rFOX, we select the account ID, then select an asset using TradeAssetSelect

It feels pretty weird to have aggregated balances in this component while we previously chosen the account

References and additional details

It would be great to be able to pass an accountId so it does select the balance for this account only, instead of every account ids

Acceptance Criteria

  • We can pass an account id to TradeAssetSelect, to avoid aggregating the balances of every account ids

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
ShapeShift Dashboard
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeOMakinG