Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Progress Bar Logic for Swap UX #8575

Open
reallybeard opened this issue Jan 14, 2025 · 1 comment
Open

Improve Progress Bar Logic for Swap UX #8575

reallybeard opened this issue Jan 14, 2025 · 1 comment

Comments

@reallybeard
Copy link
Contributor

Overview

As we've discussed with @twblack88, the current swap UX progress bar could be improved to better reflect the actual progress of a swap. The existing implementation does not account for transaction states (e.g., when a step has a txid but is not yet successful), making it less intuitive for users.

This issue aims to refine the progress bar logic to provide a more accurate representation of swap progress, considering sub-steps where applicable.

References and additional details

n/a

Acceptance Criteria

  • When a swap step receives a txid, the progress bar should reflect 50% completion for that step.
  • Once the transaction is successful, the progress bar should reflect 100% completion for that step.
  • For steps that include sub-steps:
    • Progress should increment proportionally as sub-steps are completed.
    • The completion of all sub-steps should result in the step reaching 100% completion.
  • Ensure the progress bar dynamically updates as transactions and sub-steps progress.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@reallybeard reallybeard changed the title Progress bar logic UX improvements Improve Progress Bar Logic for Swap UX Jan 14, 2025
@gomesalexandre
Copy link
Contributor

FYI @reallybeard re e.g., when a step has a txid but is not yet successful: following #8534, you can now safely assume that a buy txId means success.
Note that's when we have a buy txId only, we can and will have a sell txId immediately after broadcast, but doesn't mean success yet as we don't have a buy txId just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants