-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer for chainflip trades understated #8518
Comments
This is something which has been discussed during implementation. We have the egress time available, but it is not included to be consistent with how the other swappers (thorchain in particular) work. |
Precisely what David said @MBMaria! |
Also one more thing to note here: despite the swap seemingly taking long (i.e going to confirmed state), in reality, it is completed much faster: we detect Txs in the app, even UTXO Txs, as soon as they hit the mempool (0 confirmation) and users can spend them said UTXOs instantly. We also show them as "Confirmed" in the Tx history after 1 confirmation. However Chainflip has a 3 confirmations heuristics to assume confirmed, and since we use their API to go to trade confirmed state, things may seem very long but if you keep your Tx history open, you'll notice it's much faster to appear vs. swapper confirmed state! |
Lets revisit after #8534 is completed and go from there |
Overview
When looking at the timer on a chainflip trade, it will say the time for the first part of the trade (ie, eth to btc). Timer may say 1min 40 but that is just the eth send. The actual time of the whole trade to complete is much longer, often 20-40 mins
References and additional details
Acceptance Criteria
Timer should have accurate estimation of total trade
Need By Date
No response
Screenshots/Mockups
No response
Ownership
Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters
The text was updated successfully, but these errors were encountered: