Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer for chainflip trades understated #8518

Open
2 tasks done
MBMaria opened this issue Jan 9, 2025 · 4 comments
Open
2 tasks done

Timer for chainflip trades understated #8518

MBMaria opened this issue Jan 9, 2025 · 4 comments
Labels
bug Something isn't working needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Jan 9, 2025

Overview

When looking at the timer on a chainflip trade, it will say the time for the first part of the trade (ie, eth to btc). Timer may say 1min 40 but that is just the eth send. The actual time of the whole trade to complete is much longer, often 20-40 mins

References and additional details

image
image

Acceptance Criteria

Timer should have accurate estimation of total trade

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Jan 9, 2025
@CumpsD
Copy link
Contributor

CumpsD commented Jan 9, 2025

This is something which has been discussed during implementation. We have the egress time available, but it is not included to be consistent with how the other swappers (thorchain in particular) work.

@gomesalexandre
Copy link
Contributor

Precisely what David said @MBMaria!
We could use the more correct ETA including outbound, but then Chainflip would (wrongly) seem like a much, much longer options vs. THOR where it's just a case of us using diff. heuristics to determine ETA.

@gomesalexandre
Copy link
Contributor

Also one more thing to note here: despite the swap seemingly taking long (i.e going to confirmed state), in reality, it is completed much faster: we detect Txs in the app, even UTXO Txs, as soon as they hit the mempool (0 confirmation) and users can spend them said UTXOs instantly. We also show them as "Confirmed" in the Tx history after 1 confirmation.

However Chainflip has a 3 confirmations heuristics to assume confirmed, and since we use their API to go to trade confirmed state, things may seem very long but if you keep your Tx history open, you'll notice it's much faster to appear vs. swapper confirmed state!

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 13, 2025
@0xean
Copy link
Contributor

0xean commented Jan 13, 2025

Lets revisit after #8534 is completed and go from there

@0xean 0xean moved this from Up next / groomed to Backlog in ShapeShift Dashboard Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty
Projects
Status: Backlog
Development

No branches or pull requests

4 participants