Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to deposit into LPs on KeepKey #8369

Closed
2 tasks done
MBMaria opened this issue Dec 15, 2024 · 3 comments
Closed
2 tasks done

Unable to deposit into LPs on KeepKey #8369

MBMaria opened this issue Dec 15, 2024 · 3 comments
Assignees
@gomesalexandre @kaladinlight
Labels
blocked bug Something isn't working keepkey This is a keepkey issue needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Dec 15, 2024

Overview

Trying to deposit into ETH/RUNE Lp just spins continuously and doesn't broadcast a transaction after signing on the kk.
Able to deposit into ETH/RUNE on native

References and additional details

image
https://jam.dev/c/1c514363-be87-42e6-96cb-07248da9ae4f

Acceptance Criteria

Should be able to deposit into LP on KK

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty keepkey This is a keepkey issue labels Dec 15, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Dec 16, 2024
@gomesalexandre gomesalexandre self-assigned this Dec 16, 2024
@gomesalexandre
Copy link
Contributor

Related to the hard fork, looks like amino signing is borked for MsgDeposit (at least) - stay tuned

@gomesalexandre gomesalexandre removed their assignment Dec 17, 2024
@gomesalexandre
Copy link
Contributor

Note this should automagically work again today (US time) assuming new THORNode is released today:

https://gitlab.com/thorchain/thornode/-/merge_requests/3852

@gomesalexandre
Copy link
Contributor

RUNE signing is now unborked in all envs for hardware wallets 🎉

Note this should automagically work again today (US time) assuming new THORNode is released today:

https://gitlab.com/thorchain/thornode/-/merge_requests/3852

Image

@github-project-automation github-project-automation bot moved this from Up next / groomed to Done in ShapeShift Dashboard Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

@kaladinlight kaladinlight

Labels
blocked bug Something isn't working keepkey This is a keepkey issue needs engineering Requires engineering input before bounty
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gomesalexandre @kaladinlight @MBMaria