You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice-to-have: When signing some structured EIP-712 data withint the context of wc dApps, we just display some ugly JSON instead of making the structured data actually looking structured to the users, which effectively equals to blind signing
This is wrong twofolds:
The types property actually defines the structured data and should never be displayed to users, even if displaying raw JSON, only domain should since it is the data. If we want to fix this as a ☕ , simply make it so that we only display the domain section, beautify the JSON, and call it a day
Raw JSON is really akin to blind signing to users, non-technical users don't want to read JSON, we should make this actually look nice. Obviously a bigger effort here for a feature that may not be so used, so may or may not be worth the effort.
In comparison, this is how MM does it:
And this is how Rabby displays it:
Note Rabby also displays the raw JSON in "Sign Typed Data", but actually parses said structure
References and additional details
N/A
Acceptance Criteria
Only domain is displayed for EIP-712 data in wc dApps modal
Stretch:
Things look pretty, see Rabby/MM
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered:
Overview
Nice-to-have: When signing some structured EIP-712 data withint the context of wc dApps, we just display some ugly JSON instead of making the structured data actually looking structured to the users, which effectively equals to blind signing
This is wrong twofolds:
types
property actually defines the structured data and should never be displayed to users, even if displaying raw JSON, onlydomain
should since it is the data. If we want to fix this as a ☕ , simply make it so that we only display thedomain
section, beautify the JSON, and call it a dayIn comparison, this is how MM does it:
And this is how Rabby displays it:
Note Rabby also displays the raw JSON in "Sign Typed Data", but actually parses said structure
References and additional details
N/A
Acceptance Criteria
domain
is displayed for EIP-712 data in wc dApps modalStretch:
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered: