Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-712 structured signing for WC dApps is not actually looking structured #8228

Open
gomesalexandre opened this issue Nov 29, 2024 · 0 comments
Labels
nice to have mayyyybe one day

Comments

@gomesalexandre
Copy link
Contributor

Overview

Nice-to-have: When signing some structured EIP-712 data withint the context of wc dApps, we just display some ugly JSON instead of making the structured data actually looking structured to the users, which effectively equals to blind signing

Screenshot 2024-11-29 at 18 43 42

This is wrong twofolds:

  1. The types property actually defines the structured data and should never be displayed to users, even if displaying raw JSON, only domain should since it is the data. If we want to fix this as a ☕ , simply make it so that we only display the domain section, beautify the JSON, and call it a day
  2. Raw JSON is really akin to blind signing to users, non-technical users don't want to read JSON, we should make this actually look nice. Obviously a bigger effort here for a feature that may not be so used, so may or may not be worth the effort.

In comparison, this is how MM does it:

image

And this is how Rabby displays it:

image

Note Rabby also displays the raw JSON in "Sign Typed Data", but actually parses said structure

References and additional details

N/A

Acceptance Criteria

  • Only domain is displayed for EIP-712 data in wc dApps modal

Stretch:

  • Things look pretty, see Rabby/MM

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have mayyyybe one day
Projects
Status: Backlog
Development

No branches or pull requests

1 participant