Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account - Should group accounts addition of EVM accounts #6671

Open
gomesalexandre opened this issue Apr 11, 2024 · 1 comment
Open

Add Account - Should group accounts addition of EVM accounts #6671

gomesalexandre opened this issue Apr 11, 2024 · 1 comment
Labels
needs grooming needs product Requires product input before bounty

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Apr 11, 2024

Overview

Currently it is possible to add acounts for each chain, separately:

image

In contrast, Ledger adds all for EVM chains (note, Ethereum really refers to EVM chains here):

image

We want the "Add Account" button to act similar to the add EVM accounts for Ledger, adding all accounts for the specified account number.

Note, this issue is blocked by #6672 and assume we have removed the auto-not-so-magical account numbers discovery and should be tackled after, so that we don't end up in a scenario with the current automagical discovery, where we try to add e.g account 3 for all, but some EVM chains already have accounts 0-5, some have 0, some have 0-1 etc

References and additional details

https://github.com/shapeshift/web/blob/develop/src/pages/Accounts/AddAccountModal.tsx

Acceptance Criteria

  • All EVM accounts are now living under an "Ethereum (+ x more, where x is the amount of other EVM chains we support)" option
  • Adding "EVM accounts" adds all EVM accounts for said account number
  • The copy is reflected in the Ledger chains connection screen as well, which is doing the same

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

3 hours

@gomesalexandre gomesalexandre added the needs product Requires product input before bounty label Apr 11, 2024
@gomesalexandre gomesalexandre removed the needs product Requires product input before bounty label Apr 11, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 6, 2025
@0xean 0xean added the needs product Requires product input before bounty label Jan 6, 2025
@0xean 0xean moved this from Up next / groomed to Backlog in ShapeShift Dashboard Jan 6, 2025
@twblack88 twblack88 removed the needs product Requires product input before bounty label Jan 27, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Feb 3, 2025
@0xean 0xean added the needs product Requires product input before bounty label Feb 3, 2025
@0xean
Copy link
Contributor

0xean commented Feb 3, 2025

Product to take a quick pass on what the experience should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs grooming needs product Requires product input before bounty
Projects
Status: Up next / groomed
Development

No branches or pull requests

4 participants