Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have properties converted to Title Case to match Freecad style? #344

Open
leoheck opened this issue Jun 20, 2024 · 5 comments
Open

Comments

@leoheck
Copy link

leoheck commented Jun 20, 2024

Hey @shaise nice to meet you here. I did not know that this was also your work.
What do you think about updating property names on this Workbench too?

image

@shaise
Copy link
Owner

shaise commented Jun 20, 2024

Yes, I had a feeling it will come into this. Sheetmetal is a bit more complicated in that matter. But I will take a look as well.

@leoheck
Copy link
Author

leoheck commented Jun 20, 2024

Yes, I had a feeling it will come into this.

Sorry to give you this much work dude!

@luzpaz luzpaz added the feature label Sep 10, 2024
@luzpaz
Copy link
Collaborator

luzpaz commented Sep 10, 2024

I guess there would need to be a slow deprecation process whereby the deprecated properties need to be converted by a script for backward compatibility, notify the user that older versions of SheetMetal addon aren't compatible... ?

@leoheck
Copy link
Author

leoheck commented Sep 10, 2024

What if the priperties are read from the file as case insensitive, and converted to the title case internally. When saving the file, the title case is used?

@shaise
Copy link
Owner

shaise commented Sep 10, 2024

I think that I will probably end up doing the same as I did in Fasteners. Only reason I postponed it is because I need to see how I merge the changes that were done for Ondsel's sheetmetel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants