You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Assuming we remove this, shadowsocks-android now essentially treats all ACL files virtually the same, so it makes sense now to allow the user to completely customize ACL. Here is my proposal for improved customizable ACL.
Better maintainability
There are currently a lot of redundancy in the acl files. We can allow all ACL files to import each other, e.g. bypass-china.acl could be simply:
[proxy_all]
#IMPORT_URL https://host/path/to/gfwlist.acl
[bypass_list]
# China IP blocks here...
Host reachable anywhere
Currently we host ACL files on shadowsocks.org, which is inaccessible from China. We can get around this issue by using GitHub or other CDNs, e.g. https://cdn.jsdelivr.net/gh/shadowsocks/shadowsocks-acl@v2/gfwlist.acl.
Remove ACL GUI editor
I think GUI editor is currently a rarely used feature. We should replace it with just a list of ACL urls, much like subscriptions. Built-in ACL will also use this format, but with a built-in offline cache.
(maybe GUI editor makes more sense if it is a web editor)
After 857fb55, the only special case this repo does for ACL file is to add bypass LAN routes:
shadowsocks-android/core/src/main/java/com/github/shadowsocks/bg/VpnService.kt
Lines 192 to 206 in 857fb55
Unfortunately, this is known to be buggy on Android 10, so maybe we can remove this optimization as well.
Assuming we remove this, shadowsocks-android now essentially treats all ACL files virtually the same, so it makes sense now to allow the user to completely customize ACL. Here is my proposal for improved customizable ACL.
Better maintainability
There are currently a lot of redundancy in the acl files. We can allow all ACL files to import each other, e.g.
bypass-china.acl
could be simply:Host reachable anywhere
Currently we host ACL files on
shadowsocks.org
, which is inaccessible from China. We can get around this issue by using GitHub or other CDNs, e.g.https://cdn.jsdelivr.net/gh/shadowsocks/shadowsocks-acl@v2/gfwlist.acl
.Remove ACL GUI editor
I think GUI editor is currently a rarely used feature. We should replace it with just a list of ACL urls, much like subscriptions. Built-in ACL will also use this format, but with a built-in offline cache.
(maybe GUI editor makes more sense if it is a web editor)
Fixes #2385. Any comments? @madeye
The text was updated successfully, but these errors were encountered: