[bug]: Combobox search functionality searches values instead of labels

[tbeckett1211]

Describe the bug

The example on the web page works fine but that is because the values have the same text as the labels. Most selects will have a description as the label and some sort of ID as the value. Upon changing the values to in the examples to random strings, the search/filter does not filter based on the labels, it searches based upon the value.

Affected component/components

combobox

How to reproduce

Change values of frameworks to values that does not directly contain the same text as the labels. Then try to search for a framework in the list

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

Chrome

Before submitting

• I've made research efforts and searched the documentation
• I've searched for existing issues

[karanBRAVO]

Hey @tbeckett1211, I would like to fix this issue. Assign it to me.

[tbeckett1211]

@karanBRAVO I have no idea how to do that, however, I would really appreciate a patch for this.

[karanBRAVO]

🤩⏳ I have started working on this issue.

[BrendanC23]

Take a look at this cmdk PR. [email protected] adds a new keywords option. This Shadcn PR implements this.

Alternatively, you can write a custom filter function. See the cmdk docs.