Skip to content

Commit 044c4e0

Browse files
committed
Merge pull request moby#15334 from Mashimiao/change-name-check-for-image-delete
image_delete: move name check first
2 parents 8534090 + cb2def9 commit 044c4e0

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

daemon/image_delete.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ func (daemon *Daemon) ImageDelete(name string, force, noprune bool) ([]types.Ima
2727
}
2828

2929
func (daemon *Daemon) imgDeleteHelper(name string, list *[]types.ImageDelete, first, force, noprune bool) error {
30+
if name == "" {
31+
return fmt.Errorf("Image name can not be blank")
32+
}
33+
3034
var repoName, tag string
3135
repoAndTags := make(map[string][]string)
3236

@@ -36,10 +40,6 @@ func (daemon *Daemon) imgDeleteHelper(name string, list *[]types.ImageDelete, fi
3640
tag = tags.DefaultTag
3741
}
3842

39-
if name == "" {
40-
return fmt.Errorf("Image name can not be blank")
41-
}
42-
4343
img, err := daemon.Repositories().LookupImage(name)
4444
if err != nil {
4545
if r, _ := daemon.Repositories().Get(repoName); r != nil {
@@ -54,7 +54,6 @@ func (daemon *Daemon) imgDeleteHelper(name string, list *[]types.ImageDelete, fi
5454
}
5555

5656
byParents := daemon.Graph().ByParent()
57-
5857
repos := daemon.Repositories().ByID()[img.ID]
5958

6059
//If delete by id, see if the id belong only to one repository

0 commit comments

Comments
 (0)