Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect circle detection between util classes #39

Open
romani opened this issue Mar 19, 2018 · 4 comments
Open

incorrect circle detection between util classes #39

romani opened this issue Mar 19, 2018 · 4 comments

Comments

@romani
Copy link
Member

romani commented Mar 19, 2018

based on 2.2.0 release.

I tested it on checkstyle project, it works, report is generated.
But looks like there is problem in DSM matric content generation, some cycles I do not see in code, but this is completely different issue.
image
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtils.java
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtils.java

steps to reproduce:

git clone [email protected]:checkstyle/checkstyle.git
mvn site -Pno-validations
# look at generated report.
@romani
Copy link
Member Author

romani commented Mar 19, 2018

@jimbethancourt , I will add plugin to chekcstyle project as soon as 2.2.0 appear on maven.

Can you help us to validate plugin on correctness of work ? Plugin just render HTML base on dtangler domain object, so it hightly likely that dtangler UI will show the same.
Are you interested in maven plugin development ?

@jimbethancourt
Copy link
Contributor

Hi @romani ,
I am interested in helping, but I'm not sure when I will be able to dedicate enough time to make a lot of headway as this is a side project for me. I agree that the dtangler UI and the dsm plugin will produce the same results and that dtangler's correctness would need to be addressed.

Thanks,
Jim

@romani
Copy link
Member Author

romani commented Apr 4, 2018

Whenever you have a time. We all do open source on the side

@romani
Copy link
Member Author

romani commented Apr 4, 2018

dsm report is back to web - http://checkstyle.sourceforge.net/dsm/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants