Fix #142: catch StopIteration and return InvalidProductError

CHANGES.md

@@ -2,6 +2,7 @@
 
 ## 0.21.2 (2024-mm-dd)
 
+- FIX: `Sentinel-2` product with StopIteration error ([#142](https://github.com/sertit/eoreader/issues/142))
 - FIX: Fix `Maxar` product with `QB02` satellite ID ([#140](https://github.com/sertit/eoreader/issues/140))
 - ENH: `to_str` and `to_band`: add a `as_list` argument defaulting to `True`. When set as False, return a str from `to_str` and a band from `to_band` ([#138](https://github.com/sertit/eoreader/issues/138)). Thanks @jsetty!
 - FIX: Fix issue with geocoding with unzipped `Sentinel-3 OLCI` product ([#137](https://github.com/sertit/eoreader/issues/137))

eoreader/products/optical/landsat_product.py

@@ -1007,11 +1007,16 @@ def _read_mtd(self, force_pd=False) -> (etree._Element, dict):
                 # FOR COLLECTION 1 AND 2
                 tar_ds = None
                 try:
-                    mtd_path = next(self.path.glob(f"**/*{mtd_name}"))
-                except ValueError:
-                    mtd_path = next(self.path.glob(f"*{mtd_name}"))
-
-                if not mtd_path.is_file():
+                    try:
+                        mtd_path = next(self.path.glob(f"**/*{mtd_name}"))
+                    except ValueError:
+                        mtd_path = next(self.path.glob(f"*{mtd_name}"))
+
+                    if not mtd_path.is_file():
+                        raise InvalidProductError(
+                            f"No metadata file found in {self.name} !"
+                        )
+                except StopIteration:
                     raise InvalidProductError(
                         f"No metadata file found in {self.name} !"
                     )

eoreader/products/optical/s2_product.py

@@ -490,7 +490,7 @@ def _get_name_constellation_specific(self) -> str:
                     next(self.path.glob("**/tileInfo.json")), print_file=False
                 )
                 name = tile_info["productName"]
-            except json.JSONDecodeError:
+            except (json.JSONDecodeError, StopIteration):
                 raise InvalidProductError(
                     f"Corrupted metadata and bad filename for {self.path}! "
                     f"Impossible to process this product."

eoreader/products/optical/s3_olci_product.py

@@ -464,7 +464,12 @@ def get_raw_band_paths(self, **kwargs) -> dict:
             if self.is_archived:
                 raw_path = path.get_archived_path(self.path, f".*{filename}")
             else:
-                raw_path = next(self.path.glob(f"*{filename}"))
+                try:
+                    raw_path = next(self.path.glob(f"*{filename}"))
+                except StopIteration:
+                    raise FileNotFoundError(
+                        f"Non existing file {filename} in {self.path}"
+                    )
 
             raw_band_paths[band] = raw_path
 

eoreader/products/optical/s3_slstr_product.py

@@ -531,7 +531,10 @@ def _get_raw_band_path(self, band: BandNames, **kwargs) -> AnyPathType:
         if self.is_archived:
             raw_path = path.get_archived_path(self.path, f".*{filename}*")
         else:
-            raw_path = next(self.path.glob(f"*{filename}*"))
+            try:
+                raw_path = next(self.path.glob(f"*{filename}*"))
+            except StopIteration:
+                raise FileNotFoundError(f"Non existing file {filename} in {self.path}")
 
         return raw_path
 

eoreader/products/optical/sv1_product.py

@@ -309,7 +309,10 @@ def footprint(self) -> gpd.GeoDataFrame:
         if self.is_archived:
             footprint = vectors.read(self.path, archive_regex=r".*\.shp")
         else:
-            footprint = vectors.read(next(self.path.glob("*.shp")))
+            try:
+                footprint = vectors.read(next(self.path.glob("*.shp")))
+            except StopIteration:
+                raise FileNotFoundError(f"Non existing file *.shp in {self.path}")
 
         return footprint.to_crs(self.crs())
 

eoreader/products/optical/vhr_product.py

@@ -515,8 +515,8 @@ def _get_path(self, filename: str = "", extension: str = "") -> AnyPathType:
             else:
                 prod_path = next(self.path.glob(f"{filename}*.{extension}"))
 
-        except (FileNotFoundError, IndexError):
-            LOGGER.warning(
+        except (FileNotFoundError, IndexError, StopIteration):
+            raise InvalidProductError(
                 f"No file corresponding to *{filename}*.{extension} found in {self.path}"
             )
 

eoreader/products/sar/capella_product.py

@@ -206,12 +206,22 @@ def _post_init(self, **kwargs) -> None:
         (setting product-type, band names and so on)
         """
         # Private attributes
-        self.snap_filename = str(next(self.path.glob("*CAPELLA*.json")).name)
+        try:
+            self.snap_filename = str(next(self.path.glob("*CAPELLA*.json")).name)
+        except StopIteration:
+            raise FileNotFoundError(f"Non existing file *CAPELLA*.json in {self.path}")
         try:
             self._raw_band_regex = str(next(self.path.glob(f"{self.name}.tif")).name)
         except StopIteration:
             # For SICD and SIDD
-            self._raw_band_regex = str(next(self.path.glob(f"{self.name}.ntf")).name)
+            try:
+                self._raw_band_regex = str(
+                    next(self.path.glob(f"{self.name}.ntf")).name
+                )
+            except StopIteration:
+                raise FileNotFoundError(
+                    f"Non existing file {self.name}.tif or {self.name}.ntf in {self.path}"
+                )
 
         # Post init done by the super class
         super()._post_init(**kwargs)
@@ -235,7 +245,12 @@ def wgs84_extent(self) -> gpd.GeoDataFrame:
             gpd.GeoDataFrame: WGS84 extent as a gpd.GeoDataFrame
         """
         if self._has_stac_mtd:
-            mtd_file = next(self.path.glob(f"{self.name}.json"))
+            try:
+                mtd_file = next(self.path.glob(f"{self.name}.json"))
+            except StopIteration:
+                raise FileNotFoundError(
+                    f"Non existing file {self.name}.json in {self.path}"
+                )
             extent = vectors.read(mtd_file)
         else:
             extent = None

eoreader/products/sar/iceye_product.py

@@ -149,12 +149,17 @@ def _post_init(self, **kwargs) -> None:
         (setting product-type, band names and so on)
         """
         # Private attributes
-        if self._use_slc:
-            self.snap_filename = str(next(self.path.glob("*ICEYE*SLC*.xml")).name)
-            self._raw_band_regex = "*ICEYE*SLC*.h5"
-        else:
-            self.snap_filename = str(next(self.path.glob("*ICEYE*GRD*.xml")).name)
-            self._raw_band_regex = "*ICEYE*GRD*.tif"
+        try:
+            if self._use_slc:
+                self.snap_filename = str(next(self.path.glob("*ICEYE*SLC*.xml")).name)
+                self._raw_band_regex = "*ICEYE*SLC*.h5"
+            else:
+                self.snap_filename = str(next(self.path.glob("*ICEYE*GRD*.xml")).name)
+                self._raw_band_regex = "*ICEYE*GRD*.tif"
+        except StopIteration:
+            raise FileNotFoundError(
+                f"Non existing file *ICEYE*SLC*.xml or *ICEYE*GRD*.xml in {self.path}"
+            )
 
         # Post init done by the super class
         super()._post_init(**kwargs)

eoreader/products/sar/rs2_product.py

@@ -427,7 +427,7 @@ def wgs84_extent(self) -> gpd.GeoDataFrame:
             else:
                 extent_file = next(self.path.glob("*product.kml"))
                 product_kml = vectors.read(extent_file)
-        except IndexError as ex:
+        except (IndexError, StopIteration) as ex:
             raise InvalidProductError(
                 f"Extent file (product.kml) not found in {self.path}"
             ) from ex

eoreader/products/sar/s1_rtc_asf_product.py

@@ -165,7 +165,10 @@ def footprint(self) -> gpd.GeoDataFrame:
         if self.is_archived:
             footprint = vectors.read(self.path, archive_regex=r".*\.shp")
         else:
-            footprint = vectors.read(next(self.path.glob("*.shp")))
+            try:
+                footprint = vectors.read(next(self.path.glob("*.shp")))
+            except StopIteration:
+                raise FileNotFoundError(f"Non existing file *.shp in {self.path}")
 
         return footprint
 

eoreader/products/sar/saocom_product.py

@@ -242,7 +242,7 @@ def wgs84_extent(self) -> gpd.GeoDataFrame:
         # else:
         #     try:
         #         extent_file = next(self.path.glob("**/Images/*.kml"))
-        #     except IndexError as ex:
+        #     except (IndexError, StopIteration) as ex:
         #         raise InvalidProductError(
         #             f"Extent file (products.kml) not found in {self.path}"
         #         ) from ex
@@ -286,7 +286,10 @@ def get_raw_band_paths(self, **kwargs) -> dict:
             dict: Dictionary containing the path of every band existing in the raw products
         """
         extended_fmt = _ExtendedFormatter()
-        cuss_file = next(self.path.glob("*.zip"))
+        try:
+            cuss_file = next(self.path.glob("*.zip"))
+        except StopIteration:
+            raise FileNotFoundError(f"Non existing file *.zip in {self.path}")
         band_paths = {}
         for band in SarBandNames.speckle_list():
             band_regex = extended_fmt.format(self._raw_band_regex, band.value)

eoreader/products/sar/tsx_product.py

@@ -379,7 +379,7 @@ def wgs84_extent(self) -> gpd.GeoDataFrame:
         # Open extent KML file
         try:
             extent_file = next(self.path.glob("**/*SUPPORT/GEARTH_POLY.kml"))
-        except IndexError as ex:
+        except (IndexError, StopIteration) as ex:
             raise InvalidProductError(
                 f"Extent file (products.kml) not found in {self.path}"
             ) from ex