Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of eyre use for extract command #170

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Mar 7, 2024

Comment on lines -227 to 230
#[error("Root is invalid")]
#[error("root is invalid")]
RootInvalid,
#[error("Cache dir is invalid")]
#[error("cache directory is invalid")]
CacheInvalid,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should our root library errors start capitalized or lowercase? 🤔 And then should all context be lowercase? Consistency here lends towards a nicer UX

@tarkah tarkah force-pushed the feat/better-errors branch from d45bfb4 to 82be174 Compare March 7, 2024 23:20
@ermo ermo added type: documentation Improvements or additions to documentation. type: enhancement New feature or request labels May 14, 2024
@ermo ermo added this to the zz -- deferred milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation. type: enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants