Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[format] scriptBuilder parser executes commented out # %action statements in YML recipes #15

Open
ermo opened this issue Dec 20, 2022 · 2 comments
Labels
type: bug Something isn't working.

Comments

@ermo
Copy link
Member

ermo commented Dec 20, 2022

In a stone.yml recipe,

# %make

will (quite unexpectedly) get picked up and expanded + run by our macro parser here, essentially making # signs lose their intended meaning as "this is a comment, don't process" in YAML files and shell scripts.

One solution could be to attempt to add findSplitBefore logic, such that the lines the parser sees have already been stripped of comments as it parses them.

@ermo
Copy link
Member Author

ermo commented Dec 21, 2022

@ermo ermo closed this as completed Dec 21, 2022
@ermo ermo reopened this Jan 1, 2023
@ermo
Copy link
Member Author

ermo commented Jan 1, 2023

Needs a different solution as the "fix" well ... wasn't (it broke builds w/tmpfile macros).

@ikeycode ikeycode transferred this issue from another repository Mar 21, 2023
@livingsilver94 livingsilver94 added type: bug Something isn't working. and removed moss-format labels Jul 17, 2023
@livingsilver94 livingsilver94 changed the title The scriptBuilder parser happily executes commented out # %action statements in YML recipes [format] scriptBuilder parser executes commented out # %action statements in YML recipes Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants