Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug builds in our Dockerfiles to reduce CI times #462

Merged
merged 4 commits into from
Nov 29, 2023

Commits on Nov 28, 2023

  1. Use debug builds in our Dockerfiles to reduce CI times

    Also enables only spawning the mdns service when debug in the coordinator.
    kayabaNerve committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3e397e2 View commit details
    Browse the repository at this point in the history
  2. Correct underflow in processor

    Prior undetected due to relase builds not having bounds checks enabled.
    kayabaNerve committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    00eaa2f View commit details
    Browse the repository at this point in the history
  3. Restore Serai release due to CI/RPC failures caused by compiling it i…

    …n debug mode
    
    This is *probably* worth an issue filed upstream, if it can be tracked down.
    kayabaNerve committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2b62168 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Correct failing debug asserts in Monero

    These debug asserts assumed there was a change address to take the remainder.
    If there's no change address, the remainder is shunted to the fee, causing the
    fee to be distinct from the estimate.
    
    We presumably need to modify monero-serai such that change: None isn't valid,
    and users must use Change::Fingerprintable(None).
    kayabaNerve committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9219f6c View commit details
    Browse the repository at this point in the history