Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use debug builds in our Dockerfiles to reduce CI times #462

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Use debug builds in our Dockerfiles to reduce CI times #462

merged 4 commits into from
Nov 29, 2023

Conversation

kayabaNerve
Copy link
Member

Also enables only spawning the mdns service when debug in the coordinator.

Broken out from #455.

@kayabaNerve kayabaNerve added improvement This could be better CI/CD Continuous integration workflows labels Nov 28, 2023
@kayabaNerve
Copy link
Member Author

The processor test is a legitimate failure.

2023-11-28T06:14:14.2781401Z thread 'main' panicked at coins/monero/src/wallet/send/mod.rs:533:5:
2023-11-28T06:14:14.2782187Z assertion `left == right` failed: Outgoing amount + fee != incoming amount
2023-11-28T06:14:14.2782654Z   left: 2260500000
2023-11-28T06:14:14.2782892Z  right: 1000000000000

@kayabaNerve
Use debug builds in our Dockerfiles to reduce CI times
3e397e2 
Also enables only spawning the mdns service when debug in the coordinator.
@kayabaNerve
Correct underflow in processor
00eaa2f 
Prior undetected due to relase builds not having bounds checks enabled.
@kayabaNerve
Restore Serai release due to CI/RPC failures caused by compiling it i…
2b62168 
…n debug mode

This is *probably* worth an issue filed upstream, if it can be tracked down.
@kayabaNerve
Correct failing debug asserts in Monero
9219f6c 
These debug asserts assumed there was a change address to take the remainder.
If there's no change address, the remainder is shunted to the fee, causing the
fee to be distinct from the estimate.

We presumably need to modify monero-serai such that change: None isn't valid,
and users must use Change::Fingerprintable(None).
@kayabaNerve kayabaNerve merged commit f0ff3a1 into develop Nov 29, 2023
16 checks passed
@kayabaNerve kayabaNerve deleted the debug-orchestration branch November 29, 2023 05:24
@kayabaNerve kayabaNerve mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD Continuous integration workflows improvement This could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kayabaNerve