Improve container validation

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>

Author: pditommaso

src/main/groovy/io/seqera/wave/model/ContainerCoordinates.groovy

@@ -53,7 +53,8 @@ class ContainerCoordinates implements ContainerPath {
     static ContainerCoordinates parse(String path) {
         if( !path )
             throw new IllegalArgumentException("Container image name is not provided")
-
+        if( path.contains(' ') )
+            throw new IllegalArgumentException("Invalid container name - offending image: '$path'")
         final scheme = StringUtils.getUrlProtocol(path)
         if( scheme ) {
             if( scheme!='oras') throw new IllegalArgumentException("Invalid container scheme: '$scheme' - offending image: '$path'")

src/main/groovy/io/seqera/wave/service/validation/ValidationServiceImpl.groovy

@@ -68,14 +68,14 @@ class ValidationServiceImpl implements ValidationService {
         // check does not start with a protocol prefix
         final prot = StringUtils.getUrlProtocol(name)
         if( prot ) {
-            return "Invalid container repository name — offending value: $name"
+            return "Invalid container repository name — offending value: '$name'"
         }
 
         try {
             ContainerCoordinates.parse(name)
         }
         catch (IllegalArgumentException e) {
-            return "Invalid container image name — offending value: $name"
+            return "Invalid container image name — offending value: '$name'"
         }
         return null
     }

src/test/groovy/io/seqera/wave/service/validation/ValidationServiceTest.groovy

@@ -80,9 +80,12 @@ class ValidationServiceTest extends Specification {
         'quay.io:80/foo:latest'     | null
         'localhost:8000/foo:latest' | null
         and:
-        'docker:quay.io/foo:latest'  | 'Invalid container image name — offending value: docker:quay.io/foo:latest'
-        'http://quay.io/foo:latest'  | 'Invalid container repository name — offending value: http://quay.io/foo:latest'
-        'http://quay.io/foo:latest'  | 'Invalid container repository name — offending value: http://quay.io/foo:latest'
+        'docker:quay.io/foo:latest'  | "Invalid container image name — offending value: 'docker:quay.io/foo:latest'"
+        'http://quay.io/foo:latest'  | "Invalid container repository name — offending value: 'http://quay.io/foo:latest'"
+        'http://quay.io/foo:latest'  | "Invalid container repository name — offending value: 'http://quay.io/foo:latest'"
+        'ubuntu: latest'             | "Invalid container image name — offending value: 'ubuntu: latest'"
+        'ubuntu:latest '             | "Invalid container image name — offending value: 'ubuntu:latest '"
+        '   '                        | "Invalid container image name — offending value: '   '"
     }
 
     @Unroll