Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict EndpointDefinition#path_params, #query_params #32

Open
jwfearn opened this issue Jun 29, 2013 · 1 comment
Open

Strict EndpointDefinition#path_params, #query_params #32

jwfearn opened this issue Jun 29, 2013 · 1 comment

Comments

@jwfearn
Copy link

jwfearn commented Jun 29, 2013

The schema values accessed via EndpointDefinition#path_params and EndpointDefinition#query_params methods are not JSON Schema 3 or 4 compliant.

I believe the fix is to add the following after https://github.com/seomoz/interpol/blob/master/lib/interpol/endpoint.rb#L203:

make_schema_strict!(@path_params)
make_schema_strict!(@query_params)

related issue: #30

@jwfearn
Copy link
Author

jwfearn commented Jun 29, 2013

Another suggestion: It would be cool if EndpointDefinition#make_schema_strict! (or some variant thereof) was a public class method (it's currently a private instance method). It could be pretty useful on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant