Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryservice.brainkb.org is not served over https #6

Closed
kabilar opened this issue Oct 11, 2024 · 11 comments · Fixed by #12
Closed

queryservice.brainkb.org is not served over https #6

kabilar opened this issue Oct 11, 2024 · 11 comments · Fixed by #12
Labels
bug Something isn't working enhancement New feature or request

Comments

@kabilar
Copy link
Member

kabilar commented Oct 11, 2024

Followup discussion from here.

Error messages:
image

Hi @tekrajchhetri, I am not entirely sure why this is the case. Where is the queryservice.brainkb.org service set up?

@tekrajchhetri
Copy link
Collaborator

@kabilar the queryservice is setup in AWS EC2, separate instance. And As I showed you over the call, the https has been enabled for queryservice.

@aaronkanzer do you have any suggestions?

@tekrajchhetri
Copy link
Collaborator

The request header from network tab, when making request.
image

@tekrajchhetri
Copy link
Collaborator

Sequence diagram for the above request, where we're facing https issue.

seq-diagrams drawio

@tekrajchhetri
Copy link
Collaborator

Update: With a latest update to queryservice, I no longer see HTTPS issue as before. Rather a CORS issue.

image

@kabilar
Copy link
Member Author

kabilar commented Oct 28, 2024

Hi @tekrajchhetri, after discussion with @aaronkanzer, perhaps the assertions and evidence endpoints are not available for the queryservice (API docs) and this is why the 404 is returned. Is this evidence endpoint live?

Additionally, perhaps these GET requests needs to be against queryservice.brainkb.org instead of beta.brainkb.org:

Thanks.

@tekrajchhetri
Copy link
Collaborator

@kabilar

Please find find my answers below.

--> Yes, there will be assertion/evidence endpoint. But the error that you're seeing is not because we don't have assertion/evidence endpoint. It's because nothing has been implemented for assertions/evidence menu as of now. We will possibly start next week or so once we fix some issues with our model.

@kabilar
Copy link
Member Author

kabilar commented Nov 7, 2024

But the error that you're seeing is not because we don't have assertion/evidence endpoint. It's because nothing has been implemented for assertions/evidence menu as of now.

@tekrajchhetri Sorry, I am not exactly sure what you mean.

@tekrajchhetri
Copy link
Collaborator

@kabilar we could discuss in our meeting today.

@tekrajchhetri
Copy link
Collaborator

@kabilar closing this issue as I've resolved the issue.

@kabilar
Copy link
Member Author

kabilar commented Nov 19, 2024

Thanks @tekrajchhetri. Thats great. I will review the pull request.

Just as a heads up. Its typical practice to keep the issue open until the pull request has been merged, tested, and the changes are GA.

@tekrajchhetri
Copy link
Collaborator

@kabilar Thanks for that info, I am opening it. We can close it after we merge the pull-request.

@tekrajchhetri tekrajchhetri reopened this Nov 20, 2024
@tekrajchhetri tekrajchhetri changed the title queryservice.brainkb.org is not served over https Fix HTTPS Serving for queryservice.brainkb.org, Update SPARQL Queries for Oxigraph and Data release Nov 21, 2024
@tekrajchhetri tekrajchhetri changed the title Fix HTTPS Serving for queryservice.brainkb.org, Update SPARQL Queries for Oxigraph and Data release queryservice.brainkb.org is not served over https Nov 21, 2024
@tekrajchhetri tekrajchhetri added bug Something isn't working enhancement New feature or request labels Dec 3, 2024
tekrajchhetri added a commit that referenced this issue Dec 3, 2024
Fix HTTPS Serving for queryservice.brainkb.org (#6), Updated Data Release page and Update SPARQL Queries for Oxigraph Database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants