Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Login #14

Open
tekrajchhetri opened this issue Nov 22, 2024 · 4 comments
Open

Update: Login #14

tekrajchhetri opened this issue Nov 22, 2024 · 4 comments

Comments

@tekrajchhetri
Copy link
Collaborator

This issue is in relation to #5.

Updates:

  1. Login with Google -- removed.
  2. The token issue has been resolved and now Login with Github is working.

image

@tekrajchhetri
Copy link
Collaborator Author

Closing the issue as @puja-trivedi too had successfully tested.

@kabilar
Copy link
Member

kabilar commented Nov 26, 2024

Thanks @tekrajchhetri. I noticed that GitHub OAuth is requesting to read private profile information. If this is not necessary, I would suggest removing this requirement.

image

@kabilar
Copy link
Member

kabilar commented Nov 26, 2024

I am reopening this issue so that we can track my request. But feel free to close if you disagree.

@kabilar kabilar reopened this Nov 26, 2024
@tekrajchhetri
Copy link
Collaborator Author

@kabilar For our application, we would require the personal information like name email. This is because when making a contribution, say assertions/evidence, we would want to know who contributed and those information would be part of the user profile. So the GitHub and now ORCID will not just will be used for authentication but also to populate the user profile information.

If we think we should do it differently, I am happy to have the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants