-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting Personalization Removes Existing template_data #1037
Comments
Hi @jr-bespoke! I tried reproducing the issue using your code snippet, and saw that the dynamic template data still exists. When you create your new personalization (with two recipients & ccs) and add it to the object on line 14, the original top-level data (with the single recipient, template data & id) becomes another personalization (or separate email) under the hood. Read here to gain a clearer idea of how personalizations work & how you can meet your desired use case. Let me know if you have any other questions! |
I had the same issue that when adding personalization the dynamic template did not have any of the data. Had to do the same as ts. |
I think there's a disconnect between the code snippet provided and what the intended goal is. The issue is that dynamic template data is a part of a personalization which also includes recipients. This allows for using the same dynamic template and generating multiple personalized emails to different recipients with different dynamic template data in a single API call. This also means that a personalization generally should not be added multiple times to a single Recommend building the personalization(s) to match the goal and then adding it/them to the def our_simplified_send_func(to_, template_id, template_data, cc_recipients = []):
mail = Mail(from_email=self._from, to_emails=_to) # self._from is a class var
mail.dynamic_template_data = template_data
mail.template_id = template_id
for cc in cc_recipients:
mail.add_cc(Cc(cc, cc)) |
Closing due to lack of activity. |
Issue Summary
I am trying to determine why using
add_personalization
removes the existingdynamic_template_data
I already set on my mail object. If this is desired behavior, I would have expected some kind of note about it in the docs, or preferably a warning in the code.I tried looking in the knowledge base, on github issues, and on stack overflow. I could not find anything to suggest why this might be happening. I found the workaround by simply resetting dynamic_template_data. I could, of course, simply add the personalization first and then add the dynamic_template_data, but this seemed like a silent gotcha that should be brought to the sendgrid team's awareness.
Steps to Reproduce
Code Snippet
Exception/Log
Technical details:
The text was updated successfully, but these errors were encountered: