-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing typing #1280
Comments
Hello @assertnotnull, Great catch! When using dynamic transactional templates, we don't need to set the content values. I believe the change will need to be implemented here. This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog. With best regards, Elmer |
This was confusing to me as well. Seems to still be in there? I'm getting an error if I don't pass in a content field |
The API for Node JS is confusing and not aligned with the API:
MailData.text
&html
but there's alsoMailData.content
which is not optional when usingMailData
. The two first are not in the API doc butcontent
is https://sendgrid.com/docs/api-reference/Mail
that seems like an option to use but then the typing is not aligned with anything in the documentation. Typescript says you can't callsend
withMail
orMailJSON
.The current version forces me to set:
So it's valid Typescript even though we use template ids and values.
The text was updated successfully, but these errors were encountered: