Fix!: The ability to get Content-Type value from attachments (Inbound Parse) #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
garydevenay
changed the title
|
Thank you for the PR! Could you please update your branch with the latest updates from |
thinkingserious
added
status: waiting for feedback
eshanholtz
reviewed
Oct 28, 2020
helpers/inbound/inbound.go
Outdated
| headers := make(map[string]string) | ||
| content := readBody(emailPart) | ||
|
|
||
| headers["Content-Type"] = emailPart.Header.Get("Content-Type") |
There was a problem hiding this comment.
Why not just headers := emailPart.Header (would need to change type). Alternatively, instead of storing headers, make ContentType one of the properties of ParsedAttachment, and do some simple string parsing to extract the MIME type from the string returned by emailPart.Header.Get("Content-Type")
There was a problem hiding this comment.
I've changed the ParsedAttachment.Headers to type MIMEHeader and stored the full attachment headers in there. Also added a string ContentType to take the content type (Without the name="***" part). Updated the tests for this too.
…d parsed all attachment headers in the Headers property
eshanholtz
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
Previously we could not infer the content type of an attachment from it's contents (see #412) . I've updated the ParsedEmail Attachments property to be of (new) type ParsedAttachment. This new struct has it's "Content-Type" header populated on email parse and included tests.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.