Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error on 4xx/5xx response #121

Open
boardfish opened this issue Sep 7, 2020 · 1 comment
Open

Raise error on 4xx/5xx response #121

boardfish opened this issue Sep 7, 2020 · 1 comment
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@boardfish
Copy link

Feature Request Summary

In the event of an erroneous response, I'd like to be able to raise an exception rather than look for those error conditions manually. Faraday can already do this according to the spec I desire using the Faraday::Response::RaiseError middleware, but in this case I'm using sendgrid-ruby to make requests to SendGrid.

To introduce the change in a non-breaking way, this gem shouldn't raise errors by default.

@childish-sambino
Copy link
Contributor

Similar to sendgrid/sendgrid-csharp#775

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@childish-sambino childish-sambino added difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

2 participants