Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-5863] fix: add emoji fallback icon #219

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[CLNP-5863] fix: add emoji fallback icon #219

merged 1 commit into from
Nov 22, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 22, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-5863

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 requested a review from OnestarLee November 22, 2024 05:07
@bang9 bang9 self-assigned this Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 11.53%. Comparing base (d981ebe) to head (3d30123).

Files with missing lines Patch % Lines
...ckages/uikit-react-native/src/libs/EmojiManager.ts 0.00% 4 Missing ⚠️
...components/ReactionAddons/MessageReactionAddon.tsx 0.00% 3 Missing ⚠️
...omponents/ReactionAddons/ReactionRoundedButton.tsx 0.00% 2 Missing ⚠️
...actionBottomSheets/ReactionUserListBottomSheet.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   11.54%   11.53%   -0.01%     
==========================================
  Files         357      357              
  Lines        8454     8459       +5     
  Branches     2360     2242     -118     
==========================================
  Hits          976      976              
- Misses       7403     7482      +79     
+ Partials       75        1      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bang9 bang9 force-pushed the fix/emoji-fallback branch from 22579c9 to 3d30123 Compare November 22, 2024 05:18
Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
문제되는 샘플에서 동작되는것 확인하였습니다

@bang9 bang9 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit b021c59 Nov 22, 2024
7 checks passed
@bang9 bang9 deleted the fix/emoji-fallback branch November 22, 2024 05:20
@bang9 bang9 changed the title fix: add emoji fallback icon [CLNP-5863] fix: add emoji fallback icon Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants