Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't search more than one tag at a time #57

Closed
GKSN opened this issue Nov 11, 2022 · 6 comments
Closed

Can't search more than one tag at a time #57

GKSN opened this issue Nov 11, 2022 · 6 comments

Comments

@GKSN
Copy link

GKSN commented Nov 11, 2022

I'm not able to search more than one tag at once.

Version
1.4.1
Last Updated
April 23, 2022
Firefox
Mac OS

@seeba8
Copy link
Owner

seeba8 commented Nov 12, 2022

Good suggestion in general! What would you expect, would you interpret searching for multiple tags as an "AND" or "OR"?

Leaving aside that maybe adding a domain-specific search language providing more search syntax could be cool, I'm not sure I'm up for the implementation challenge of that.

I've been thinking about doing some code cleanup in this addon because think there's room for improvement in there. I'll see what I can do when I have time, but no promises.

@GKSN
Copy link
Author

GKSN commented Nov 12, 2022

Hi,
I would go with an "OR" logic but if possible I would let an option to use the "AND".
By the way, great addon !

seeba8 added a commit that referenced this issue Nov 20, 2022
@seeba8 seeba8 mentioned this issue Nov 20, 2022
@seeba8
Copy link
Owner

seeba8 commented Nov 20, 2022

I've added four options for searching (to be set via the options menu of the addon):

  • Result must contain the exact search phrase
  • Result must contain all words of the search phrase, but in any order (this is the new default)
  • Result must contain at least one of the words in the search phrase (Can't search more than one tag at a time #57)
  • Result must match the regular expression search

It should update in your browser sometime in the next days. It's already accepted on addons.mozilla.org and pending review on chromium.

In case you use a chromium-derived browser, let me know if you see any bugs, I only did a few cursory tests since my main browser is firefox.

@GKSN
Copy link
Author

GKSN commented Nov 20, 2022

Nice! :-)
I will test everything as soon as the update takes place. My main browser is Firefox too but I'll test on both browsers.

Since we're here... There is one little thing that I was having trouble with, when I try to use the the "shift + alt + p" it doesn't work unless I open and close ( alt + p ) the list first. I will do more tests to see if it's only with my browser.

By the way , thanks for the update! 👍

@seeba8
Copy link
Owner

seeba8 commented Nov 25, 2022

Alt+Shift+P works for me directly (funny that, I forgot it is able to do that, I am too mouse-bound myself). If you find a way to reproduce the issue, let me know.

Maybe also check in about:addons > cogwheel > manage extension shortcuts whether you have any conflicting keybinds?

@GKSN
Copy link
Author

GKSN commented Nov 25, 2022

So far I test it on Firefox and it appears that everything is working great !
After the update the "shift + alt + p" is working again, maybe it was something I did but for now, is back to normal. I'll keep you posted.

@GKSN GKSN closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants