Add @seda-protocol/utils #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
force-pushed
the
chore/seda-bun-utils
branch
from
5cf8fb4
to
141b0a7
Compare
Thomasvdam
force-pushed
the
chore/seda-bun-utils
branch
from
141b0a7
to
ce2320c
Compare
mariocao
reviewed
Oct 1, 2024
Comment on lines
+51
to
+55
| "@noble/secp256k1": "2.1.0", | ||
| "@seda-protocol/utils": "^1.0.0", | ||
| "@types/node-gzip": "^1.1.1", | ||
| "@wasmer/wasi": "^1.2.2", | ||
| "as-bignum": "^0.3.1", |
mariocao
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't be merged until the new package is merged and published, and the package.json here has been updated.
Motivation
Less code duplication.
Explanation of Changes
Migrate from a local copy of the test utilities to the ones in
@seda-protocol/utilsTesting
See https://github.com/sedaprotocol/seda-explorer/pull/513 on how this was set up.
All the tests still pass, the build builds, and the CLI works as expected.
Related PRs and Issues
https://github.com/sedaprotocol/seda-explorer/pull/513