Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage cache should use relative paths. #947

Open
thirsch opened this issue Oct 20, 2022 · 2 comments
Open

Coverage cache should use relative paths. #947

thirsch opened this issue Oct 20, 2022 · 2 comments

Comments

@thirsch
Copy link
Contributor

thirsch commented Oct 20, 2022

Q A
php-code-coverage version >= 9.2.17
Installation Method Composer
Usage Method PHPUnit
PHPUnit version (if used) 9.5.25

The cache file lookup uses the absolute path of both, the cache scripts of this project (introduced here: acd254e) and the absolut path of covered file of the project under test. As we are running subsequent builds of our project in different paths (including the build number e.g.), we can't use the cache much, as every run causes a miss and would only produce tons of duplicates in a shared cache folder.

Would it be possible to change both path to use relative path to the files? As both methods are using the content of the file as well, it should be sufficient to build unique cache hashes. What do you think?

@Legion112
Copy link

Duplicate of #925

@sebastianbergmann
Copy link
Owner

Duplicate of #925

Not really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants