Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max. booking duration not working when daily basis only is activated #366

Open
Plack-Blague opened this issue Nov 27, 2024 · 0 comments
Open

Comments

@Plack-Blague
Copy link

Good afternoon,

First of all, congratulations on this project; it seems very well thought out and useful.

I’m not sure if this is a bug or just how the program is designed to work.

Actual Behavior:

  1. When the "Allow bookings on a daily basis only" option is activated, the "Max. booking duration" is not enforced, allowing users to book without limits.
  2. Additionally, if this option is activated, it allows bookings that exceed the "Max. days in advance" limit, as it appears to only check the "Entry" day.

Expected Behavior:

  1. The "Max. booking duration" should enforce the limit on the total booking hours, even when the daily basis option is active. For example, if the booking starts at 00:00 on day 1 and ends at 23:59 on day 2, it should count as 47 hours and 59 minutes.
  2. The program should also check the "Leave" time. If the leave time exceeds the "Max. days in advance" limit, the booking should not be allowed.

We expect this behavior because we don’t want users to book more than one week in advance, and since our setup is small for now, there is no need to go into the detail of using hours. The further in advance a booking is made, the higher the chances that users might forget to cancel if their plans change, which results in inefficient use of the workstations.

A suggestion could be to create separate settings for hours and days, implementing a grey-out feature to disable configurations that are not activated.

Thank you for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant