Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Compiler Warning #5

Open
aksuska opened this issue Jul 19, 2013 · 2 comments
Open

Minor Compiler Warning #5

aksuska opened this issue Jul 19, 2013 · 2 comments

Comments

@aksuska
Copy link
Contributor

aksuska commented Jul 19, 2013

GCUndoManager.m, -perform
Implicit signedness conversion at lines 1331 and 1334--seems better to just declare "i" as NSUInteger, as that seems consistent with use.
@seanm
Copy link
Owner

seanm commented Jul 23, 2013

Care to create a pull request? Also, be sure that the 'while' loop does not need reformulating... 0-1 is different with signed vs unsigned math...

@aksuska
Copy link
Contributor Author

aksuska commented Jul 23, 2013

The while loop is OK I think--I added some discussion of overflow issues in the pull request. It all depends on how likely the method will be invoked on an empty group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanm @aksuska