Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize validate method for multi-table synthesizers #2291

Open
frances-h opened this issue Nov 13, 2024 · 0 comments
Open

Modularize validate method for multi-table synthesizers #2291

frances-h opened this issue Nov 13, 2024 · 0 comments
Labels
feature request Request for a new feature

Comments

@frances-h
Copy link
Contributor

Problem Description

Currently, we cannot easily extend validation for multi-table synthesizers because most of the functionality is contained in the public BaseMultiTableSynthesizer.validate method. We should modularize the validate method so it can be extended more easily.

Expected behavior

In order to support additional validation functionality, we should move the existing validation functionality out of the validate method and into the helper method _validate. The validate method should just call _validate.

Additionally, in the preprocess method, validation of the data should occur before the _transform_helper method is called on the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant