Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enforce_min_max_datetimes parameter to datetime transformers #538

Open
amontanez24 opened this issue Aug 17, 2022 · 0 comments
Open
Labels
feature request Request for a new feature

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it would be good if there was a way to ensure the data reversed by datetime transformers was within the bounds of the real data.

Expected behavior

  • Add a boolean parameter called enforce_min_max_datetimes to the UnixTimestampEncoder and OptimizedTimestampEncoder.
  • The default value should be False.
  • If enabled:
    • the min and max datetimes should be learned during the fit
    • during the reverse transform, the data should be clipped to the bounds learned during fit
@amontanez24 amontanez24 added the feature request Request for a new feature label Aug 17, 2022
@npatki npatki modified the milestone: 1.3.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants