AggregateStatusConditions can produce invalid Condition

[rzetelskik]

AggregateStatusConditions helper func can produce invalid conditions. There are two reasons:

1. condition.Reason is constructed by concatenating Type and Reason of aggregated conditions:

   scylla-operator/pkg/controllerhelpers/core.go

   Line 64 in fe5d18c

   reasons = append(reasons, fmt.Sprintf("%s_%s", c.Type, c.Reason))

   
   Valid condition.Type needs to match (dns1123SubdomainFmt/)?(qualifiedNameFmt). Valid condition.Reason must be a CamelCase string. A valid Type does not always pass Reason's validation, e.g. Node_gke-so-331fe2c9-c118-489f-890-default-dfaf2fab-vb36_Progressing is a valid Type, but not a valid Reason.
2. constructed fields can go over the size limit, there's even a TODO left:

   scylla-operator/pkg/controllerhelpers/core.go

   Line 71 in fe5d18c

   // TODO: Strip aggregated reasons and messages to fit into API limits.

/kind bug

[scylla-operator-bot]

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 30d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out

/lifecycle stale

[scylla-operator-bot]

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 30d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out

/lifecycle rotten

[rzetelskik]

/remove-lifecycle rotten
/triage accepted