-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
must-gather
doesn't anonymize many things when running Scylla in GCP
#2015
Comments
The Scylla Operator project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
/lifecycle stale |
The Scylla Operator project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
/lifecycle rotten |
Still valid! I just had to anonymize manually again in #2133. |
/remove-lifecycle stale |
/remove-lifecycle rotten |
None of these are part of the API so I don't think we can automatically redact them and sometimes some of them may matter. Although, I struggle to see the secrecy of say GCR image names.
It already says you may want to review it. I don't think "required" is fitting here. In Kubernetes secret data is supposed to be stored in Secrets.
https://operator.docs.scylladb.com/v1.14/support/must-gather.html#gathering-data-with-must-gather |
What happened?
I did a run of
must-gather
as documented at https://operator.docs.scylladb.com/stable/support/must-gather.html.After grepping for some names I noticed that the data collected didn't anonymize some things:
What did you expect to happen?
I was expecting these names to be anonymized.
Instead I had to do a bunch of recursive find and replace (
grep -rl old . | xargs sed -i "" -e 's/old/new/g'
) myself...At the minimum, the warning in the docs about checking the gathered data should be emphasized and turn into a required step.
How can we reproduce it (as minimally and precisely as possible)?
must-gather
Scylla Operator version
1.13.0
Kubernetes platform name and version
Please attach the must-gather archive.
I can't attach the non-anonymized archive because that's the point here. The additionally manually anonymized version is in #2016.
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: