Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager should not manage more than 5 OSS clusters #4018

Open
mykaul opened this issue Sep 4, 2024 · 6 comments
Open

Manager should not manage more than 5 OSS clusters #4018

mykaul opened this issue Sep 4, 2024 · 6 comments

Comments

@mykaul
Copy link
Contributor

mykaul commented Sep 4, 2024

Based on their versions, Manager should not allow to manage more than 5 open source clusters. It should emit a nice error message explaining the limitation when someone tries to add the 6th.

@tzach
Copy link
Collaborator

tzach commented Sep 5, 2024

ScyllaDB Manager is free to use for all customers up to 5 nodes for clusters built with ScyllaDB Open Source. Customers using ScyllaDB Enterprise can connect an unlimited number of nodes with clusters deployed across multiple datacenters.
https://www.scylladb.com/download/open-source/scylla-manager/

  • License is for 5 nodes, not clusters.
  • This should (or can) be part of a bigger Enterprise enforcement feature.

@Michal-Leszczynski
Copy link
Collaborator

This is about informing good-willed users that didn't remember about this limitation?
Since SM is open source, they can always fork the repo and remove this limitation from the code.

Also, would SM verify that given cluster is Enterprise based only on the Scylla version?
If I understand correctly, images with Scylla Enterprise are also available to anyone, so not only the customers.

@karol-kokoszka
Copy link
Collaborator

karol-kokoszka commented Sep 16, 2024

As per @Michal-Leszczynski, let's check if the cluster consists of Scylla Enterprise servers or of OSS ones.
If the cluster is the OSS one, do the check on:

  • task start -> log / return an error whenever it's discovered that cluster is OSS and the size is > 5
  • adding the cluster

@Michal-Leszczynski
Copy link
Collaborator

@tzach is it possible that some paying customer is using open source Scylla instead of the enterprise one?
If that's possible, then we can't return the error on failed check. We can just log it or print it in the sctool output.

@tzach
Copy link
Collaborator

tzach commented Sep 16, 2024

@tzach is it possible that some paying customer is using open source Scylla instead of the enterprise one?

It is possible, but not common.

@Michal-Leszczynski
Copy link
Collaborator

So there we can't return an error when there is a 100 node open source cluster added to SM.
We can just log/print some additional message, but SM will continue to work as always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants