Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Replace From<&T> for TT impls with T::to_TT methods #177

Open
muzarski opened this issue Sep 20, 2024 · 0 comments
Open

rust: Replace From<&T> for TT impls with T::to_TT methods #177

muzarski opened this issue Sep 20, 2024 · 0 comments
Assignees
@muzarski
Labels
good first issue Good for newcomers

Comments

@muzarski
Copy link
Collaborator

We should not implement From<> trait for borrowed types. See https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv. All appearances of From<&T> for TT should be replaced with T::to_TT methods.
@muzarski muzarski added the good first issue Good for newcomers label Sep 20, 2024
@muzarski muzarski self-assigned this Sep 20, 2024
@muzarski muzarski mentioned this issue Sep 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muzarski muzarski

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@muzarski