New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRASHIT() macro should set pointer to NULL in usrsctplib/user_queue.h #666

Open

ddkilzer opened this issue Nov 11, 2022 · 1 comment

ddkilzer commented Nov 11, 2022

TRASHIT() macro should set pointer to NULL in usrsctplib/user_queue.h.

This is just a hardening measure to make sure stale pointers are not left in next/prev struct members.

Also fixed here:

Bug 247637: TRASHIT() macro should set pointer to NULL in usrsctp/usrsctplib/usrsctplib/user_queue.h
WebKit/WebKit@3e2573a

The text was updated successfully, but these errors were encountered:

Author

ddkilzer commented Nov 11, 2022

Last I looked, usrsctp only used LIST_REMOVE() and TAILQ_REMOVE(), so this minimal change would cover the current code:

- #define	TRASHIT(x)
+ #define	TRASHIT(x)	do {(x) = (void *)0;} while (0)

The WebKit fix went a little further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment