Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withElasticSearchLogger continues past (Logger -> IO r) action when EL is unreachable #49

Open
jonathanjouty opened this issue May 29, 2019 · 1 comment
Assignees

Comments

@jonathanjouty
Copy link
Contributor

As per title, if your Elasticsearch cluster is unreachable or cannot accept messages for whatever reason, withElasticSearchLogger will keep going even though the (Logger -> IO r) action completed.

This is not completely counter to the documentation, which states that:

Create an elasticSearchLogger for the duration of the given action, and shut it down afterwards, making sure that all buffered messages are actually written to the Elasticsearch store.

The question is more about how this should work—I would prefer if it actually gave up after some time... since Elasticsearch can easily be unavailable.

Maybe an extra timeout parameter?

cc/ @arybczak @23Skidoo @phadej

@23Skidoo 23Skidoo self-assigned this Jun 11, 2019
@jonathanjouty
Copy link
Contributor Author

Ping @arybczak @phadej @23Skidoo
Any preferred solution before we start working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants