Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Measureless" files with identically named implicit measures crash the MusicXML parser #142

Open
NyuBlara opened this issue Dec 3, 2024 · 0 comments
Labels
bug Something isn't working musicxml

Comments

@NyuBlara
Copy link
Collaborator

NyuBlara commented Dec 3, 2024

This is due to an underlying bug in musicxml-interfaces, see : jocelyn-stericker/musicxml-interfaces#20

Since the repo for this lib appears to be dead, and in lieu of a time-consuming fork fixing this bug, a middleman function could perhaps be introduced as a patch, which would rename identically-numbered measures, although they do seem to be well-supported by Musescore as well as OSMD, so it definitely looks like a fault on the part of musicxml-interfaces itself.

@NyuBlara NyuBlara added musicxml bug Something isn't working labels Dec 3, 2024
NyuBlara added a commit that referenced this issue Dec 5, 2024
A file is without measures if all of its timewise measures are set to 
implicit. A file without time signatures is without beats.

Under these conditions, measureEnd and measureStarts, as well as 
isOnBeat() are irrelevant. MFP.js picks up on this and sends a signal to 
MFP.vue to deactivate the granularity picker, as well as to OSMD to hide 
the time signatures (because OSMD adds a 4/4 time signature by default).

This has been tested to work with Satie's Gnossienne n°1, with the 
exception of its identically-numbered implicit measures being renumbered 
to distinct identifiers (a bug related to musicxml-interfaces, see 
#142).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working musicxml
Projects
None yet
Development

No branches or pull requests

1 participant