consider note and command events with velocity 0 as end events

[josephlarralde]

As the title says : to stay coherent with common MIDI abusing practice (i.e note on with velocity 0 is considered a note off), we should consider that note and command events with velocity 0 are end events and not start events (Events::isStart specializations should be modified accordingly)

[smoothdeveloper]

member x.IsStart =
  match event with
  | NoteOn(_, _ , 0) | NoteOff(_, _, _) -> Some false
  | NoteOn(_) -> Some true
  | _ -> None

[josephlarralde]

Hi @smoothdeveloper ! Long time no talk ...

[smoothdeveloper]

I'm still on the line because I didn't parse the note on which is in fact a note off :D