add core exceptions #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurnzZ
commented
Feb 25, 2022
| @@ -0,0 +1,13 @@ | |||
| class ReloadResponseData(Exception): | |||
There was a problem hiding this comment.
I was thinking of a way to indicate the maximum retry attempts in this exception.
However, it's best to leave that to the framework using web-poet to standardize limits, delays, etc.
BurnzZ
commented
Apr 5, 2022
| pass | ||
|
|
||
|
|
||
| class DelegateFallback(Exception): |
There was a problem hiding this comment.
should be split into expected and unexpected fallback requests. One of them should trigger some sort of alerts or monitoring actions (e.g. unexpected layouts).
|
LGTM! These exceptions look like a good solution to common scenarios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #22.
RequestBackendErrorto this new module