Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new 'str' functionality #54

Merged
merged 1 commit into from
Aug 27, 2020
Merged

add new 'str' functionality #54

merged 1 commit into from
Aug 27, 2020

Conversation

renancunha
Copy link
Contributor

As discussed at #53, it implements the str functionality. It also modifies the extract_price function to use builtins.str instead of str, in order to avoid conflicts evaluating the expressions of price extraction.

BurnzZ
BurnzZ approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@BurnzZ BurnzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @renancunha !

akshayphilar
akshayphilar approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@akshayphilar akshayphilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @renancunha 🎉

@renancunha renancunha merged commit 50431fd into master Aug 27, 2020
@akshayphilar akshayphilar deleted the feature-str branch August 29, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnzZ BurnzZ BurnzZ approved these changes

@akshayphilar akshayphilar akshayphilar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renancunha @akshayphilar @BurnzZ